Skip to content

fix: small tweaks #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

totomanov
Copy link

@totomanov totomanov commented Jan 6, 2025

  • inline _getUnitPresentValue
  • cap solvency ratio to 1 (donation attacks)
  • ensure base == pt || ct in constructor
  • short circuiting
  • rm baseDecimals and quoteDecimals from immutables
  • store baseTokenDecimals as immutable
  • forge fmt
  • rm unused import
  • minify interfaces to contain only used methods
  • follow solidity style guide for declaration order

@adam-hamden adam-hamden merged commit 5b51705 into pitch-foundation:hourglass-linear-price-oracle Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants