feat: add optimization for finding the best CURIE #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaeladler, thank you, will review asap. |
|
@michaeladler, thanks again for submitting the pull request. It's a useful feature. I would appreciate if you fix 3 linter errors in the new code. I'll be happy to approve after that. |
- Build a map for searching for a matching IRI when computing the inverse context. Each letter of an IRI can be used to key into the map to find the best set of partial matches (which can be used to create CURIEs). - This approach is a faster alternative to trying each possible term in the active context as a possible CURIE, linearly, one at a time. Signed-off-by: Michael Adler <michael.adler@siemens.com>
michaeladler
force-pushed
the
feat/fast-curie-map
branch
from
0750860 to
0c3dbf0
Compare
|
Yes of course, sorry I forgot to run the linter. It's fixed now. |
|
Thank you. PR merged. I've also published a new release (v0.6.0) that contains your feature. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a port of a performance optimization for framing objects, originally implemented in jsonld.js.
Motivation
This optimization significantly improves performance when framing a large number of objects. For example, when framing ~ 10,000 objects, it's almost twice as fast.
Checks
make test