Skip to content

Commit 3622313

Browse files
glittersharkvmx
authored andcommitted
Remove set_disable_data_sync
This is removed from rocksdb core as of facebook/rocksdb@eb912a9, and having the reference in the ffi causes loading the shared library to break.
1 parent 8283b5d commit 3622313

File tree

3 files changed

+0
-7
lines changed

3 files changed

+0
-7
lines changed

librocksdb-sys/src/lib.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -677,8 +677,6 @@ extern "C" {
677677
pub fn rocksdb_options_set_max_sequential_skip_in_iterations(opt: *mut rocksdb_options_t,
678678
v: uint64_t);
679679

680-
pub fn rocksdb_options_set_disable_data_sync(opt: *mut rocksdb_options_t, v: c_int);
681-
682680
pub fn rocksdb_options_set_disable_auto_compactions(opt: *mut rocksdb_options_t, v: c_int);
683681

684682
pub fn rocksdb_options_set_delete_obsolete_files_period_micros(opt: *mut rocksdb_options_t,

src/db_options.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -381,10 +381,6 @@ impl Options {
381381
allow as c_uchar) }
382382
}
383383

384-
pub fn set_disable_data_sync(&mut self, disable: bool) {
385-
unsafe { ffi::rocksdb_options_set_disable_data_sync(self.inner, disable as c_int) }
386-
}
387-
388384
/// Enable direct I/O mode for reading
389385
/// they may or may not improve performance depending on the use case
390386
///

src/lib.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ pub struct BlockBasedOptions {
134134
/// opts.set_max_open_files(10000);
135135
/// opts.set_use_fsync(false);
136136
/// opts.set_bytes_per_sync(8388608);
137-
/// opts.set_disable_data_sync(false);
138137
/// opts.optimize_for_point_lookup(1024);
139138
/// opts.set_table_cache_num_shard_bits(6);
140139
/// opts.set_max_write_buffer_number(32);

0 commit comments

Comments
 (0)