Skip to content

Commit 1ef3e90

Browse files
authored
nitpick changes
1 parent 3795232 commit 1ef3e90

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

builder/frameworks/espidf.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ def load_custom_sdkconfig_file():
238238
print(f"Path Traversal detected: {url} check your URL path")
239239
else:
240240
try:
241-
response = requests.get(file_entry.split(" ")[0])
241+
response = requests.get(file_entry.split(" ")[0], timeout=10)
242242
if response.ok:
243243
return response.content.decode('utf-8')
244244
except requests.RequestException as e:
@@ -318,6 +318,9 @@ def add_flash_configuration(config_flags):
318318
return config_flags
319319

320320
def write_sdkconfig_file(idf_config_flags, checksum_source):
321+
if "arduino" not in env.subst("$PIOFRAMEWORK"):
322+
print("Error: Arduino framework required for sdkconfig processing")
323+
return
321324
"""Write the final sdkconfig.defaults file with checksum."""
322325
sdkconfig_src = join(arduino_libs_mcu, "sdkconfig")
323326
sdkconfig_dst = join(PROJECT_DIR, "sdkconfig.defaults")

0 commit comments

Comments
 (0)