chore: replace readable-stream with built-in stream #542
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Nov 8, 2024
.github/workflows/ci.yml
Outdated
| @@ -40,7 +40,7 @@ jobs: | |||
| contents: read | |||
| strategy: | |||
| matrix: | |||
| node-version: [18.17, 20, 22] | |||
| node-version: [18.19, 20, 22] | |||
There was a problem hiding this comment.
isn't that technically a semver major? I'd rather use the opportunity to drop node 18 from the list altogether
|
@kibertoad we just bumped the major, I don't think we need another bump. |
|
cc @jsumners |
|
We probably should have done it then, but I'm really not opposed to version churn on this module. I consider this module non-essential, and as such don't think it matters too much how often it is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #541