Navigation/Breadcrumbs in filerunner, pull Nav into a component #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment failed with the following error: |
|
@bdsqqq is attempting to deploy a commit to the Ping Labs Team on Vercel. To accomplish this, @bdsqqq needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
bdsqqq
changed the title
…n`, use new button dropdown in filebrowser
* better contrast * add breadcrumbs and open file button to filerunner * I had the branch with the wrong name on my local machine 💀💀💀 --------- Co-authored-by: Mark R. Florkowski <mark.florkowski@gmail.com>
* add logs for directory creation (#90) * [W-74] Fix nested folder creation (#93) * fix * also fix for file creation * only show debug logs in dev (#86) * better contrast (#89) * update v0.6.2 (#94) --------- Co-authored-by: Mark R. Florkowski <mark.florkowski@gmail.com> Co-authored-by: Theo Browne <me@t3.gg>
…fault but optional
…ng once sounds better than debugging that
| } = style; | ||
| return classNames( | ||
| BUTTON_CLASSES, | ||
| // TODO igor: ask for feedback: pointer events none here prevents the cursor from being showed as not allowed |
There was a problem hiding this comment.
Personally I prefer showing as not allowed as it is clearer than pointer events none. @t3dotgg any opinion?
apps/cli/cli-core/src/open-file.ts
Outdated
There was a problem hiding this comment.
@t3dotgg Please test on windows. I think start should open the default program for a file, but internet could be lying.
t3dotgg
approved these changes
Apr 3, 2023
…asier EG: setting up truncate needs children to be the direct child of the element with truncate, with the span there it was annoying and I'd have to do [&>span]:truncate in the button, and thats annoying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.