chore: housekeeping 2 - emit ts-sourcemaps & monorepo config stuff #103
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
juliusmarminge
changed the title
| async onSuccess() { | ||
| // emit sourcemap to enable jump to definition | ||
| execSync("pnpm tsc --project tsconfig.sourcemap.json"); | ||
| }, |
There was a problem hiding this comment.
this is the stuff that generates the sourcemaps that allows jump-to-definition
juliusmarminge
changed the title
| "@ianvs/prettier-plugin-sort-imports", | ||
| "prettier-plugin-tailwindcss", | ||
| ], | ||
| importOrder: [ |
There was a problem hiding this comment.
Can you add "<TYPES>" to the end of the sort order? Mixing type imports with regular imports gets a bit confusing at times.
There was a problem hiding this comment.
you want separate type imports? so like
import { foo } from "foo";
import type { Bar } from "foo";
DW I'll resolve it all 😇 |
| @@ -115,10 +117,13 @@ The `@uploadthing/solid` package includes an "Uploader" component that you can s | |||
| ```tsx copy | |||
| // You need to import our styles for the button to look right. Best to import in the root /layout.tsx but this is fine | |||
| import "@uploadthing/solid/styles.css"; | |||
|
|
|||
| import { type VoidComponent } from "solid-js"; | |||
There was a problem hiding this comment.
Is there anything we can do to prefer
import type { ... } from "some-package"
over
import { type ... } from "some-package"
There was a problem hiding this comment.
I don't know if there is a way to force you to change inline-type to separate ones, but with the current setup the auto fix is set to use separate-types.
Maybe the eslint-plugin-import has an option for this
There was a problem hiding this comment.
There was a problem hiding this comment.
CleanShot.2023-05-28.at.10.00.03.mp4
now only top-level are allowed
CleanShot.2023-05-26.at.23.38.09.mp4