Address image preview review feedback

Author: StiensWout

apps/web/src/browser/openFileInPreview.test.ts

@@ -100,35 +100,35 @@ describe("openFileInPreview", () => {
     expect(JSON.stringify(error)).not.toContain("signed-secret-token");
     expect(openPreview).not.toHaveBeenCalled();
   });
-});
 
-it("does not apply an older preview response after another caller starts a newer request", async () => {
-  const firstSnapshot = snapshot("tab-1", "https://assets.test/first.png");
-  const secondSnapshot = snapshot("tab-2", "https://assets.test/second.png");
-  let resolveFirst!: (result: AtomCommandResult<PreviewSessionSnapshot, never>) => void;
-  const openPreview: OpenPreviewMutation<never> = ({ input }) =>
-    input.url === "https://assets.test/first.png"
-      ? new Promise<AtomCommandResult<PreviewSessionSnapshot, never>>((resolve) => {
-          resolveFirst = resolve;
-        })
-      : Promise.resolve(AsyncResult.success(secondSnapshot));
-
-  const firstRequest = openUrlInPreview({
-    threadRef,
-    url: "https://assets.test/first.png",
-    openPreview,
-  });
+  it("does not apply an older preview response after another caller starts a newer request", async () => {
+    const firstSnapshot = snapshot("tab-1", "https://assets.test/first.png");
+    const secondSnapshot = snapshot("tab-2", "https://assets.test/second.png");
+    let resolveFirst!: (result: AtomCommandResult<PreviewSessionSnapshot, never>) => void;
+    const openPreview: OpenPreviewMutation<never> = ({ input }) =>
+      input.url === "https://assets.test/first.png"
+        ? new Promise<AtomCommandResult<PreviewSessionSnapshot, never>>((resolve) => {
+            resolveFirst = resolve;
+          })
+        : Promise.resolve(AsyncResult.success(secondSnapshot));
+
+    const firstRequest = openUrlInPreview({
+      threadRef,
+      url: "https://assets.test/first.png",
+      openPreview,
+    });
 
-  await openUrlInPreview({
-    threadRef,
-    url: "https://assets.test/second.png",
-    openPreview,
-  });
-  resolveFirst(AsyncResult.success(firstSnapshot));
-  await firstRequest;
+    await openUrlInPreview({
+      threadRef,
+      url: "https://assets.test/second.png",
+      openPreview,
+    });
+    resolveFirst(AsyncResult.success(firstSnapshot));
+    await firstRequest;
 
-  expect(readThreadPreviewState(threadRef).snapshot).toEqual(secondSnapshot);
-  expect(
-    selectThreadRightPanelState(useRightPanelStore.getState().byThreadKey, threadRef).surfaces,
-  ).toEqual([{ id: "browser:tab-2", kind: "preview", resourceId: "tab-2" }]);
+    expect(readThreadPreviewState(threadRef).snapshot).toEqual(secondSnapshot);
+    expect(
+      selectThreadRightPanelState(useRightPanelStore.getState().byThreadKey, threadRef).surfaces,
+    ).toEqual([{ id: "browser:tab-2", kind: "preview", resourceId: "tab-2" }]);
+  });
 });

apps/web/src/components/ChatView.tsx

@@ -2991,7 +2991,10 @@ function ChatViewContent(props: ChatViewProps) {
           stackedThreadToast({
             type: "warning",
             title: "Unable to open image preview",
-            description: error instanceof Error ? error.message : "Opening the file instead.",
+            description:
+              error instanceof Error
+                ? `${error.message} Opening the file instead.`
+                : "Opening the file instead.",
           }),
         );
         openFallback();

apps/web/src/components/DiffPanel.tsx

@@ -541,7 +541,10 @@ export default function DiffPanel({
           stackedThreadToast({
             type: "warning",
             title: "Unable to open image preview",
-            description: error instanceof Error ? error.message : "Opening the file instead.",
+            description:
+              error instanceof Error
+                ? `${error.message} Opening the file instead.`
+                : "Opening the file instead.",
           }),
         );
         openFallback();