playground: Add --perf for starting cluster for higher performance #2535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wish <breezewish@outlook.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/XL
xhebox
approved these changes
May 6, 2025
Contributor
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently playground cluster is boot for debug-friendly by default.
What is changed and how it works?
Add
--perfto allow the cluster boot for higher performance instead of debug friendly.Currently only TiFlash config is polished (and is sufficient for testing the TiDB cluster using VectorDBBench). Other config can be also added if someone need it.
Now there are more and more global options. It makes code hard to read. So I reorganized these options and grouped them into a single structure. In this way it is more clear and will be easy to add global options later.
Check List
Tests
Tested with --perf, --mode=tidb-cse and all works as expected.
Release notes: