*: check cluster version #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-integration-tests |
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
================================================
+ Coverage 30.8896% 32.3802% +1.4906%
================================================
Files 71 70 -1
Lines 7857 6995 -862
================================================
- Hits 2427 2265 -162
+ Misses 5265 4560 -705
- Partials 165 170 +5 |
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
amyangfei
reviewed
May 15, 2020
pkg/util/check.go
Outdated
| req, err := http.NewRequestWithContext( | ||
| ctx, http.MethodGet, fmt.Sprintf("%s/pd/api/v1/version", pdHTTP), nil) | ||
| if err != nil { | ||
| return errors.Annotatef(err, "fail to request PD 1") |
There was a problem hiding this comment.
Suggested change
| return errors.Annotatef(err, "fail to request PD 1") | |
| return errors.Annotate(err, "fail to request PD 1") |
ditto for other errors follows
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-integration-tests |
5kbpers
pushed a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add version check when starting CDC server and CDC client. It impls #542 task 9.
It also passes context to PD client and may help #562 .
Fix #564
Check List
Tests
Code changes
Related changes
Release note