codec(ticdc): use handlekey instead of primary key for avro

[zhangyangyu]

What problem does this PR solve?

Issue Number: close #5597

What is changed and how it works?

Avro shall use Handle Key as message key in case when there is no primary key, we could still try to use a not null unique key , makes downstream easy to use these events.

When there is no handle key, such as force replica situations, Avro message keys would be null. Downstream consumers need to accomodate for this. (This is already the current behavriour)

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• 3AceShowHand
• maxshuang
• zhaoxinyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[zhangyangyu]

/run-all-tests

[lance6716]

avro codec should use unique key as message key when there is no primary key

we could still try to use a not null unique key

I remember handle key is not a "not null unique key", please check it @3AceShowHand

[zhangyangyu]

avro codec should use unique key as message key when there is no primary key

we could still try to use a not null unique key

I remember handle key is not a "not null unique key", please check it @3AceShowHand

how do you think @leoppro

[codecov-commenter]

Codecov Report

Merging #5601 (69a3b15) into master (fcea4d5) will increase coverage by 0.2313%.
The diff coverage is 60.3972%.

Flag	Coverage Δ
cdc	61.4082% <62.1713%> (+0.2601%)	⬆️
dm	51.9832% <56.4728%> (-0.0595%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5601        +/-   ##
================================================
+ Coverage   56.0768%   56.3082%   +0.2313%     
================================================
  Files           535        673       +138     
  Lines         70143      78667      +8524     
================================================
+ Hits          39334      44296      +4962     
- Misses        27078      30226      +3148     
- Partials       3731       4145       +414     

[liuzix]

There should be an end-to-end test for this issue. Holding for now.

[lance6716]

avro codec should use unique key as message key when there is no primary key

we could still try to use a not null unique key

I remember handle key is not a "not null unique key", please check it @3AceShowHand

how do you think @leoppro

I have checked the code, the HandleKey flag is fine.

[zhangyangyu]

/run-all-tests

[liuzix]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 5e10ff5

[ti-chi-bot]

@zhangyangyu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[zhangyangyu]

/run-all-tests

[lance6716]

/unhold

[liuzix]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 69a3b15

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5605.