Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline(ticdc): fix table actor cyclic node bug #5600

Merged
merged 6 commits into from
May 27, 2022

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented May 26, 2022

What problem does this PR solve?

Issue Number: close #5599

What is changed and how it works?

Cyclic Node is not initialized correctly in table actor mode, this pr will fix it

Check List

Tests

  • Unit test
  • Integration test

Release note

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 26, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-triage-completed labels May 26, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 26, 2022
@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a714f69

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2022
@sdojjy
Copy link
Member Author

sdojjy commented May 26, 2022

/run-all-tests

@codecov-commenter
Copy link

Codecov Report

Merging #5600 (ada40e9) into master (fcea4d5) will increase coverage by 0.1168%.
The diff coverage is 60.4081%.

Flag Coverage Δ
cdc 61.5570% <62.1827%> (+0.4089%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5600        +/-   ##
================================================
+ Coverage   56.0768%   56.1936%   +0.1168%     
================================================
  Files           535        528         -7     
  Lines         70143      69700       -443     
================================================
- Hits          39334      39167       -167     
+ Misses        27078      26810       -268     
+ Partials       3731       3723         -8     

@ti-chi-bot
Copy link
Member

@sdojjy: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sdojjy
Copy link
Member Author

sdojjy commented May 27, 2022

/run-verify-test

1 similar comment
@sdojjy
Copy link
Member Author

sdojjy commented May 27, 2022

/run-verify-test

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5609.

@sdojjy sdojjy deleted the fix-table-actor-cyclic-bug branch May 27, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cyclic Node is not initialized correctly in table actor mode
5 participants