Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relay, syncer(dm): rename UUIDSuffix to RelaySubDirSuffix and others #5566

Merged
merged 8 commits into from
May 27, 2022
Merged

relay, syncer(dm): rename UUIDSuffix to RelaySubDirSuffix and others #5566

merged 8 commits into from
May 27, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented May 24, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4287

What is changed and how it works?

make some concepts more clear. Most changes are renaming.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • GMHDBJD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 24, 2022
@pingcap pingcap deleted a comment from ti-chi-bot May 24, 2022
@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label May 24, 2022
@lance6716 lance6716 changed the title relay, syncer(dm): rename UUIDSuffix relay, syncer(dm): rename UUIDSuffix to RelaySubDirSuffix and others May 24, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 24, 2022
@lance6716 lance6716 requested review from D3Hunter and GMHDBJD and removed request for D3Hunter May 26, 2022 02:19
D3Hunter
D3Hunter reviewed May 26, 2022
View reviewed changes
dm/pkg/streamer/hub.go Show resolved Hide resolved
dm/pkg/utils/relay.go Outdated Show resolved Hide resolved
dm/syncer/streamer_controller.go Show resolved Hide resolved
D3Hunter
D3Hunter reviewed May 26, 2022
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

dm/syncer/streamer_controller.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 26, 2022
@lance6716
Copy link
Contributor Author

ping @GMHDBJD

@lance6716 lance6716 requested a review from lichunzhu May 27, 2022 09:28
GMHDBJD
GMHDBJD approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b5e422b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 013acc0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit 21a78f8 into pingcap:master May 27, 2022
@lance6716 lance6716 deleted the rename-uuidsuffix branch October 13, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-chi-bot @D3Hunter @GMHDBJD