Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Trace error #176

Merged
merged 1 commit into from
Dec 16, 2019
Merged

*: Trace error #176

merged 1 commit into from
Dec 16, 2019

Conversation

zier-one
Copy link
Contributor

What problem does this PR solve?

using errors.Trace() to trace most of errors in CDC

Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzaku suzaku added the LGT1 label Dec 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #176 into master will increase coverage by 0.01%.
The diff coverage is 9.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   49.53%   49.54%   +0.01%     
==========================================
  Files          50       50              
  Lines        4108     4109       +1     
==========================================
+ Hits         2035     2036       +1     
  Misses       1850     1850              
  Partials      223      223
Impacted Files Coverage Δ
cdc/kv/etcd.go 29.46% <0%> (ø) ⬆️
cdc/roles/storage/etcd.go 75.42% <0%> (ø) ⬆️
cdc/capture.go 0% <0%> (ø) ⬆️
cdc/owner.go 33.08% <0%> (ø) ⬆️
cdc/puller/puller.go 0% <0%> (ø) ⬆️
cdc/kv/client.go 8.01% <0%> (ø) ⬆️
cdc/owner_operator.go 0% <0%> (ø) ⬆️
cdc/scheduler.go 52.86% <0%> (ø) ⬆️
cdc/sink/mysql.go 52.54% <22.22%> (+0.18%) ⬆️
cdc/txn/txn.go 78.78% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80ee381...11c6362. Read the comment docs.

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added LGT2 and removed LGT1 labels Dec 16, 2019
@zier-one zier-one merged commit 2c8f044 into pingcap:master Dec 16, 2019
@zier-one zier-one deleted the trace_err branch December 16, 2019 03:35
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
amyangfei pushed a commit to amyangfei/tiflow that referenced this pull request May 6, 2022
* lib: fix unstable tests

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants