Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvclient: filter the old value if old-value is disabled (#1304) #1347

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 26, 2021

cherry-pick #1304 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In ticdc repo:
git pr https://github.com/pingcap/ticdc/pull/1347

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/ticdc.git pr/1347:release-4.0-6a7d5ce31565

What problem does this PR solve?

fix #1299

What is changed and how it works?

set Oldvalue to nil when old-value is disabled

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Fix the old-value switch of a changefeed could be affected by another changefeed

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@codecov-io
Copy link

codecov-io commented Jan 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-4.0@f7db19c). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-4.0      #1347   +/-   ##
================================================
  Coverage               ?   47.5398%           
================================================
  Files                  ?        130           
  Lines                  ?      13109           
  Branches               ?          0           
================================================
  Hits                   ?       6232           
  Misses                 ?       6209           
  Partials               ?        668           

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 26, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit eb66cf3 into pingcap:release-4.0 Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants