README: Remove stale 'Check and Build' status#12635
Conversation
ti-chi-bot
Bot
added
do-not-merge/needs-linked-issue
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the Build Status badge from the README.md file. Feedback was provided indicating that removing this badge without a replacement or explanation makes the project's CI status unclear. The reviewer suggested updating the badge URL if the workflow was renamed and requested that the pull request description be completed according to the repository's contribution guidelines.
|  | ||
|  | ||
|  | ||
| [](https://github.com/pingcap/tiflow/actions/workflows/check_and_build.yaml?query=event%3Apush+branch%3Amaster) |
There was a problem hiding this comment.
The 'Build Status' badge is a key indicator of project health. Removing it without a replacement or explanation (the PR description is currently empty) makes it unclear if CI is still active or if the workflow was simply renamed. If a replacement workflow exists, please update the badge URL instead of removing it. Additionally, please update the PR description to include the required 'Issue Number', a summary of the changes, and complete the 'Check List' as per the repository's contribution guidelines.
There was a problem hiding this comment.
/gemini it wasn't renamed
There was a problem hiding this comment.
Understood. If the 'Build Status' badge is no longer relevant or if the workflow was removed, please ensure the PR description is updated to reflect this change, as the current description is minimal. Additionally, please complete the 'Check List' in the PR description as per the repository's contribution guidelines to ensure all necessary steps for the PR are covered.
ti-chi-bot
Bot
added
do-not-merge/needs-triage-completed
and removed
do-not-merge/needs-linked-issue
labels
|
/cc @OliverS929 |
|
/check-issue-triage-complete |
|
/cc @GMHDBJD |
1 participant
What problem does this PR solve?
Issue Number: close #12636
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note