Skip to content

Upgrade github.com/go-sql-driver/mysql#12633

Open
dveeden wants to merge 1 commit into
pingcap:masterfrom
dveeden:upgrade_go-sql-driver_mysql
Open

Upgrade github.com/go-sql-driver/mysql#12633
dveeden wants to merge 1 commit into
pingcap:masterfrom
dveeden:upgrade_go-sql-driver_mysql

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented May 12, 2026

What problem does this PR solve?

Issue Number: ref #12629

What is changed and how it works?

Upgrade go-sql-driver/mysql as preparation for upgrading go-mysql, which we need to do for Tagged GTID support.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the github.com/go-sql-driver/mysql dependency from version 1.7.1 to 1.8.1 in the go.mod and go.sum files. I have no feedback to provide.

@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2026
@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented May 12, 2026

/retest

1 similar comment
@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented May 13, 2026

/retest

@ti-chi-bot ti-chi-bot Bot added the area/dm Issues or PRs related to DM. label May 13, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented May 13, 2026

/test pull-verify

@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented May 13, 2026

/retest

@dveeden dveeden force-pushed the upgrade_go-sql-driver_mysql branch from 4c03bae to 021a581 Compare May 15, 2026 07:33
@dveeden dveeden changed the title Upgrade github.com/go-sql-driver/mysql to v1.8.1 Upgrade github.com/go-sql-driver/mysql to v1.10.0 May 15, 2026
@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented May 15, 2026

/cc @OliverS929

@ti-chi-bot ti-chi-bot Bot requested a review from OliverS929 May 15, 2026 07:34
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@dveeden dveeden force-pushed the upgrade_go-sql-driver_mysql branch from 021a581 to 104342b Compare May 15, 2026 08:51
@dveeden dveeden changed the title Upgrade github.com/go-sql-driver/mysql to v1.10.0 Upgrade github.com/go-sql-driver/mysql May 15, 2026
@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented May 15, 2026

/retest

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented May 15, 2026

@dveeden: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dm-integration-test-next-gen 104342b link false /test pull-dm-integration-test-next-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant