Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ErrGCTTLExceeded changefeed panic #3128

Closed
3AceShowHand opened this issue Oct 25, 2021 · 3 comments · Fixed by #4085
Closed

Remove ErrGCTTLExceeded changefeed panic #3128

3AceShowHand opened this issue Oct 25, 2021 · 3 comments · Fixed by #4085
Assignees
Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 affects-5.3 area/ticdc Issues or PRs related to TiCDC. bug-from-internal-test Bugs found by internal testing. component/cli CLI component. severity/major type/bug The issue is confirmed as a bug.

Comments

@3AceShowHand
Copy link
Contributor

3AceShowHand commented Oct 25, 2021

What did you do?

tiup playground v.5.1.1

update mysql.tidb set VARIABLE_VALUE="10s" where VARIABLE_NAME="tikv_gc_run_interval";

./bin/cdc server --pd=http://127.0.0.1:2379 --gc-ttl=120

./bin/cdc cli changefeed create --pd=http://127.0.0.1:2379 --sink-uri="mysql://root:123456@127.0.0.1:3306/" --changefeed-id="gcttl-test"

./bin/cdc cli changefeed pause --pd=http://127.0.0.1:2379 --changefeed-id="gcttl-test"

wait for a few minutes, changefeed's status become error, then:

./bin/cdc cli changefeed remove --pd=http://127.0.0.1:2379 --changefeed-id="gcttl-test"

What did you expect to see?

changefeed removed successfully.

What did you see instead?

20211025-164148

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

v5.1.1

TiCDC version (execute cdc version):

v5.1.1

ticdc.log

@3AceShowHand 3AceShowHand added the type/bug The issue is confirmed as a bug. label Oct 25, 2021
@3AceShowHand 3AceShowHand added bug-from-internal-test Bugs found by internal testing. component/cli CLI component. labels Oct 27, 2021
@maxshuang maxshuang added the area/ticdc Issues or PRs related to TiCDC. label Nov 8, 2021
@zhaoxinyu
Copy link
Contributor

zhaoxinyu commented Dec 24, 2021

This bug cannot be reproduced on v5.3.0. The immediate cause for this bug is passing a nil value to s.Func. See

https://github.com/pingcap/tiflow/blob/v5.1.1/pkg/orchestrator/interfaces.go#L55

@3AceShowHand
Copy link
Contributor Author

it's fine to close the issue.

@zhaoxinyu
Copy link
Contributor

it's fine to close the issue.

The nil pointer still needs to be checked. I will submit a PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.0 affects-5.0 affects-5.1 affects-5.2 affects-5.3 area/ticdc Issues or PRs related to TiCDC. bug-from-internal-test Bugs found by internal testing. component/cli CLI component. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants