Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve sink failure interrupting replication in Old Owner #2295

Closed
2 tasks done
liuzix opened this issue Jul 15, 2021 · 1 comment · Fixed by #2605
Closed
2 tasks done

Solve sink failure interrupting replication in Old Owner #2295

liuzix opened this issue Jul 15, 2021 · 1 comment · Fixed by #2605
Assignees
@asddongmen
Labels
area/ticdc Issues or PRs related to TiCDC. component/replica-model Replication model component. difficulty/medium Medium task. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@liuzix
Copy link
Contributor

liuzix commented Jul 15, 2021 •
edited by asddongmen
Loading

Irresponsive downstreams will block the owner until the operation times out. For example, if the Kafka broker is down and the owner tries to send a checkpoint event, the owner would not be able to do ANYTHING until the Kafka sink has timed out (if ever). This will only happen in the old owner.

Action item

  • Back port asyncSink to the old owner
  • Make old owner's DDL execution asynchronous (in changefeed.go)
@liuzix liuzix added type/bug The issue is confirmed as a bug. component/replica-model Replication model component. labels Jul 15, 2021
@asddongmen asddongmen self-assigned this Jul 22, 2021
@asddongmen asddongmen added the difficulty/medium Medium task. label Jul 27, 2021
This was referenced Aug 5, 2021
Closed
Merged
@asddongmen asddongmen mentioned this issue Aug 23, 2021
Merged
@asddongmen asddongmen linked a pull request Aug 23, 2021 that will close this issue
async_sink: backport async sink to 5.0-branch old owner #2605
Merged
@amyangfei
Copy link
Contributor

This issue is finished

@AkiraXie AkiraXie added the area/ticdc Issues or PRs related to TiCDC. label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asddongmen asddongmen

Labels
area/ticdc Issues or PRs related to TiCDC. component/replica-model Replication model component. difficulty/medium Medium task. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

async_sink: backport async sink to 5.0-branch old owner asddongmen/tiflow
5 participants
@amyangfei @liuzix @asddongmen @AkiraXie @Tammyxia