Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goroutine leak in MySQL sink #1160

Closed
amyangfei opened this issue Dec 2, 2020 · 1 comment
Closed

goroutine leak in MySQL sink #1160

amyangfei opened this issue Dec 2, 2020 · 1 comment
Labels
area/ticdc Issues or PRs related to TiCDC. priority/P1 The issue has P1 priority. severity/major type/bug The issue is confirmed as a bug.

Comments

@amyangfei
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.
  • pause a changefeed
  1. What did you expect to see?

    changefeed stops and all related routines exits

  2. What did you see instead?

Some goroutines are leaked

goroutine 486812 [semacquire, 1208 minutes]:
sync.runtime_Semacquire(0xc076166f10)
	runtime/sema.go:56 +0x42
sync.(*WaitGroup).Wait(0xc076166f08)
	sync/waitgroup.go:130 +0x64
github.com/pingcap/ticdc/cdc/sink.(*mysqlSinkWorker).waitAllTxnsExecuted(...)
	github.com/pingcap/ticdc@/cdc/sink/mysql.go:683
github.com/pingcap/ticdc/cdc/sink.(*mysqlSink).notifyAndWaitExec.func1(0xc21112d040, 0xc0c7346660)
	github.com/pingcap/ticdc@/cdc/sink/mysql.go:608 +0x51
created by github.com/pingcap/ticdc/cdc/sink.(*mysqlSink).notifyAndWaitExec
	github.com/pingcap/ticdc@/cdc/sink/mysql.go:606 +0x91
  1. Versions of the cluster

    • Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

      v4.0.8
      
    • TiCDC version (execute cdc version):

      v4.0.8
      
@amyangfei amyangfei added type/bug The issue is confirmed as a bug. priority/P1 The issue has P1 priority. labels Dec 2, 2020
@amyangfei
Copy link
Contributor Author

amyangfei commented Jun 22, 2021

has been fixed by #1524, #1929

@AkiraXie AkiraXie added the area/ticdc Issues or PRs related to TiCDC. label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. priority/P1 The issue has P1 priority. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

3 participants