From 9155f4268a0b2a3deab698d61ee018010fb38030 Mon Sep 17 00:00:00 2001 From: lance6716 Date: Fri, 4 Nov 2022 15:25:00 +0800 Subject: [PATCH] fix a data race Signed-off-by: lance6716 --- dm/config/task.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/dm/config/task.go b/dm/config/task.go index e9c911ff32e..473b6105767 100644 --- a/dm/config/task.go +++ b/dm/config/task.go @@ -22,6 +22,7 @@ import ( "sort" "strconv" "strings" + "sync" "time" "github.com/coreos/go-semver/semver" @@ -1008,11 +1009,16 @@ func AdjustDBTimeZone(config *DBConfig, timeZone string) { config.Session["time_zone"] = timeZone } -var defaultParser = parser.New() +var ( + defaultParser = parser.New() + parserMu sync.Mutex +) func checkValidExpr(expr string) error { expr = "select " + expr + parserMu.Lock() _, _, err := defaultParser.Parse(expr, "", "") + parserMu.Unlock() return err }