Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task might leak in corner cases #5584

Open
yibin87 opened this issue Aug 10, 2022 · 0 comments
Open

Task might leak in corner cases #5584

yibin87 opened this issue Aug 10, 2022 · 0 comments

Comments

@yibin87
Copy link
Contributor

yibin87 commented Aug 10, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!
It's detected when we enable random_tunnel_init_rpc_failure_failpoint. The whole story is like:

  1. When Tiflash servers receive MPPTasks, they first do some preparation work and then register to TaskManager. And if TiDB's cancelMPPTask request came before thre registering, the task won't be cancelled. The task still have chances to fail itself if tunnel/receiver can pass the error message.
  2. Since init_rpc failpoint will fail task very quickly, so it happened to reproduce such cases.

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant