-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BitLength
function push down
#5105
Comments
BitLength
function push downBitLength
function push down
/assign |
Hi @Willendless , @ywqzzy, can you give some hint on how to run integration tests? |
If you want to test your own code in integration test:
|
I am very interested in this issue and want to try it. Moreover, I have successfully built the tiflash project so far. Plz assign me. |
/unassign Unassign this issue due to no more comments/PR and no response to #5092 (comment) |
@isHuangXin you can leave a comment to assign yourself when you are free |
/assign |
I'm already starting to debug the whole process, but I'm feeling confused. As the document describes that the pushdown function is initiated from the TiDB side. The scalarExprSupportedByFlash in /tidb/expression/expression.go will determine which functions can be pushed down to TiFlash for execution. But I didn't find ast.bitLength in scalarExprSupportedByFlash function. Instead, I found ast.BitLength in scalarExprSupportedByTiKV. Does this mean that I should implement the ast.length function in tidb first, and then push down the ast.bitLength function in tidb to tiflash. |
Feature Request
Describe the feature you'd like:
We'd like to support
BitLength
function push down.Teachability, Documentation, Adoption, Migration Strategy:
At least one integration test and several unit tests.
The text was updated successfully, but these errors were encountered: