Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NullEq function push down #5102

Open
Willendless opened this issue Jun 10, 2022 · 3 comments · May be fixed by #6057
Open

Implement NullEq function push down #5102

Willendless opened this issue Jun 10, 2022 · 3 comments · May be fixed by #6057
Assignees
@JigaoLuo
Labels
component/compute good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement. type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@Willendless
Copy link
Contributor

Feature Request

Describe the feature you'd like:

We'd like to support NullEq function push down.

Teachability, Documentation, Adoption, Migration Strategy:

At least one integration test and several unit tests.
@Willendless Willendless added the type/feature-request Categorizes issue or PR as related to a new feature. label Jun 10, 2022
@Willendless Willendless mentioned this issue Jun 10, 2022
Open
@ywqzzy ywqzzy added type/enhancement The issue or PR belongs to an enhancement. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. component/compute labels Jun 13, 2022
@Willendless Willendless changed the title Call For Participation: implement NullEq function push down Implement NullEq function push down Jun 13, 2022
@mathspanda
Copy link

/assign

@JigaoLuo
Copy link
Contributor

JigaoLuo commented Sep 21, 2022 •
edited
Loading

/assign
Let me try. It seems a series of functions:

    //{tipb::ScalarFuncSig::NullEQInt, "cast"},
    //{tipb::ScalarFuncSig::NullEQReal, "cast"},
    //{tipb::ScalarFuncSig::NullEQString, "cast"},
    //{tipb::ScalarFuncSig::NullEQDecimal, "cast"},
    //{tipb::ScalarFuncSig::NullEQTime, "cast"},
    //{tipb::ScalarFuncSig::NullEQDuration, "cast"},
    //{tipb::ScalarFuncSig::NullEQJson, "cast"},

But in TiDB it just only one ast.NullEQ.

Doc:

This was referenced Sep 22, 2022
Open
Open
@JigaoLuo
Copy link
Contributor

Related Issue: pingcap/tidb#38098

@JigaoLuo JigaoLuo linked a pull request Sep 28, 2022 that will close this issue
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JigaoLuo JigaoLuo

Labels
component/compute good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement. type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature Implementation NullEq function push down JigaoLuo/tiflash
4 participants
@mathspanda @ywqzzy @JigaoLuo @Willendless