privilege: alter table && rename privilege make same with MySQL #9872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables use of the ALTER TABLE statement to change the structure of tables. ALTER TABLE also requires the CREATE and INSERT privileges.
same with MySQL.
Renaming a table requires ALTER and DROP on the old table, CREATE, and INSERT on the new table.
xiekeyi98
commented
Mar 24, 2019
|
|
Codecov Report
@@ Coverage Diff @@
## master #9872 +/- ##
================================================
- Coverage 67.3512% 67.3501% -0.0011%
================================================
Files 383 383
Lines 80444 80466 +22
================================================
+ Hits 54180 54194 +14
- Misses 21421 21422 +1
- Partials 4843 4850 +7 |
Codecov Report
@@ Coverage Diff @@
## master #9872 +/- ##
================================================
- Coverage 77.7215% 77.7049% -0.0167%
================================================
Files 403 403
Lines 81873 81942 +69
================================================
+ Hits 63633 63673 +40
- Misses 13547 13572 +25
- Partials 4693 4697 +4 |
crazycs520
reviewed
Mar 24, 2019
xiekeyi98
commented
Mar 25, 2019
winkyao
reviewed
Mar 26, 2019
| @@ -1640,6 +1640,39 @@ func (s *testPlanSuite) TestVisitInfo(c *C) { | |||
| {mysql.AllPrivMask, "test", "ttt", "", nil}, | |||
| }, | |||
| }, | |||
| { | |||
| sql: "alter table t add column a int(4)", | |||
There was a problem hiding this comment.
Please remember to update our document.
There was a problem hiding this comment.
zz-jason
reviewed
Mar 30, 2019
xiekeyi98
commented
Mar 31, 2019
xiekeyi98
commented
Mar 31, 2019
|
@zz-jason PTAL. |
|
/run-all-tests |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
|
/run-common-tests tidb-test=pr/776 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In MySQL:https://dev.mysql.com/doc/refman/5.7/en/privileges-provided.html#priv_alter
What is changed and how it works?
Add more privileges in
alter tableandrenameto make the same with MySQL.Check List
Tests
This change is