Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: tiny update for the whitelist plugin #9271

Merged
merged 12 commits into from
Feb 12, 2019
Merged

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

The whitelist plugin need those changes.

What is changed and how it works?

  • expose the domain.GetEtcdClient function
  • use flush status to notify the update of whitelist
  • domainMap.Get now returns the domain if it's the only one

Check List

Tests

  • Manual test (add detailed scripts or steps below

@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #9271 into master will decrease coverage by 0.03%.
The diff coverage is 2.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9271      +/-   ##
==========================================
- Coverage   67.25%   67.22%   -0.04%     
==========================================
  Files         371      371              
  Lines       77234    77268      +34     
==========================================
- Hits        51947    51943       -4     
- Misses      20649    20683      +34     
- Partials     4638     4642       +4
Impacted Files Coverage Δ
plugin/spi.go 100% <ø> (ø) ⬆️
domain/domain.go 40.31% <0%> (-0.15%) ⬇️
executor/simple.go 66.39% <0%> (-2.88%) ⬇️
server/server.go 49.3% <0%> (-3.51%) ⬇️
session/tidb.go 77.93% <25%> (-1.65%) ⬇️
ddl/delete_range.go 77.77% <0%> (-1.59%) ⬇️
util/filesort/filesort.go 75.54% <0%> (-0.95%) ⬇️
executor/join.go 77.86% <0%> (-0.53%) ⬇️
executor/index_lookup_join.go 77.91% <0%> (+0.63%) ⬆️
store/tikv/lock_resolver.go 42.65% <0%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 469fa87...12c776b. Read the comment docs.

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
PTAL @lysu

@jackysp
Copy link
Member

jackysp commented Feb 12, 2019

/run-all-tests

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 12, 2019
@jackysp jackysp merged commit c3f64b2 into pingcap:master Feb 12, 2019
@tiancaiamao tiancaiamao deleted the whitelist branch May 26, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/plugin status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants