Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: change release icon always show the latest tag #8974

Merged
merged 2 commits into from
Jan 8, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Jan 8, 2019

What problem does this PR solve?

Make README Always show the latest(largest) tag version. Currently README will always get the latest-published version.
change

to

What is changed and how it works?

change
https://img.shields.io/github/release/pingcap/tidb.svg
to
https://img.shields.io/github/tag/pingcap/tidb.svg?label=release

Check List

Tests

  • No Code

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

Codecov Report

Merging #8974 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8974      +/-   ##
==========================================
+ Coverage    67.5%   67.52%   +0.01%     
==========================================
  Files         363      363              
  Lines       75216    75216              
==========================================
+ Hits        50777    50789      +12     
+ Misses      19950    19942       -8     
+ Partials     4489     4485       -4
Impacted Files Coverage Δ
store/tikv/lock_resolver.go 41.7% <0%> (-0.95%) ⬇️
executor/join.go 76.27% <0%> (ø) ⬆️
executor/distsql.go 73% <0%> (+0.46%) ⬆️
util/filesort/filesort.go 76.48% <0%> (+0.94%) ⬆️
ddl/delete_range.go 74.28% <0%> (+1.71%) ⬆️
ddl/session_pool.go 93.1% <0%> (+10.34%) ⬆️
util/systimemon/systime_mon.go 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884db0a...984e89a. Read the comment docs.

Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 merged commit 76de7f1 into pingcap:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants