Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gomod: update tidb-tools version #8945

Merged
merged 3 commits into from
Jan 8, 2019
Merged

gomod: update tidb-tools version #8945

merged 3 commits into from
Jan 8, 2019

Conversation

AndrewDi
Copy link
Contributor

@AndrewDi AndrewDi commented Jan 4, 2019 •
edited by c4pt0r
Loading

What problem does this PR solve?

Update tidb-tools version, so that we can build tidb on windows.

What is changed and how it works?

Update tidb-tools version in go.mod.

Check List

Tests

  • No code

This change is Reviewable

@AndrewDi
Copy link
Contributor Author

AndrewDi commented Jan 4, 2019

/run-all-tests

@zz-jason
Copy link
Member

zz-jason commented Jan 5, 2019

@WangXiangUSTC PTAL

@zz-jason zz-jason requested a review from WangXiangUSTC January 5, 2019 13:30
@zz-jason zz-jason added contribution This PR is from a community contributor. component/tools labels Jan 5, 2019
@WangXiangUSTC
Copy link
Contributor

/run-unit-test

@WangXiangUSTC
Copy link
Contributor

LGTM

zimulala
zimulala approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Jan 8, 2019
@codecov-io
Copy link

codecov-io commented Jan 8, 2019 •
edited
Loading

Codecov Report

Merging #8945 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8945      +/-   ##
==========================================
+ Coverage   67.53%   67.54%   +<.01%     
==========================================
  Files         363      363              
  Lines       75264    75264              
==========================================
+ Hits        50831    50834       +3     
+ Misses      19943    19938       -5     
- Partials     4490     4492       +2
Impacted Files Coverage Δ
executor/executor.go 66.61% <0%> (-0.43%) ⬇️
util/filesort/filesort.go 76.48% <0%> (+0.31%) ⬆️
executor/distsql.go 73% <0%> (+0.46%) ⬆️
expression/schema.go 94.95% <0%> (+0.84%) ⬆️
store/tikv/lock_resolver.go 42.65% <0%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b2c14...cb1b112. Read the comment docs.

@winoros winoros merged commit c68ee73 into pingcap:master Jan 8, 2019
zhexuany pushed a commit to zhexuany/tidb that referenced this pull request Jan 10, 2019
@AndrewDi @zhexuany
gomod: update tidb-tools version (pingcap#8945)
b534295
@AndrewDi AndrewDi deleted the update_tidb_tools branch January 16, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees
No one assigned
Labels
component/tools contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndrewDi @zz-jason @WangXiangUSTC @codecov-io @zimulala @winoros