Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove redundant "errors.Trace()" in "expression" package #8609

Merged
merged 2 commits into from
Dec 7, 2018

Conversation

ziyi-yan
Copy link
Contributor

@ziyi-yan ziyi-yan commented Dec 6, 2018

What problem does this PR solve?

fixes #8216

What is changed and how it works?

Replace all errors.Trace() to err (or the argument of errors.Trace() calls).

To get goword check passed, fix some comments.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

This change is Reviewable

@sre-bot
Copy link
Contributor

sre-bot commented Dec 6, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@ziyi-yan ziyi-yan force-pushed the remove-redundant-errors-trace branch from c9fea68 to 9a6d2e3 Compare December 6, 2018 17:04
@jackysp jackysp added the contribution This PR is from a community contributor. label Dec 7, 2018
@jackysp
Copy link
Member

jackysp commented Dec 7, 2018

Thanks, @ziyi-yan !
/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@lysu PTAL

@zz-jason zz-jason added type/enhancement The issue or PR belongs to an enhancement. status/LGT1 Indicates that a PR has LGTM 1. labels Dec 7, 2018
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Close #8216

@ngaut ngaut merged commit d9e02b7 into pingcap:master Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove redundant "errors.Trace()" in the "expression" package
5 participants