Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikvclient: Add endKey param to Scanner (#8178) #8309

Merged
merged 5 commits into from
Nov 19, 2018

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Nov 14, 2018

What problem does this PR solve?

This PR cherry-picks #8178 (d125958) to release-2.0 branch. So the end_key param will be supported in release-2.0 branch. This helps fixing a bug that scanning out-of-bound may cause TiKV panic.

This PR requires tikv/tikv#3780 and #8308 be merged first.

What is changed and how it works?

This PR cherry-picks #8178 (d125958) to release-2.0 branch.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has interface methods change

Side effects

  • None

Related changes

  • None

This change is Reviewable

MyonKeminta and others added 2 commits November 14, 2018 13:26
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@zz-jason zz-jason changed the title [DNM] [release-2.0] cherry-pick: tikvclient: Add endKey param to Scanner (#8178) tikvclient: Add endKey param to Scanner (#8178) Nov 14, 2018
@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 15, 2018
@zz-jason
Copy link
Member

/run-all-tests tikv=release-2.1 pd=release-2.1 tidb-test=release-2.1

@MyonKeminta
Copy link
Contributor Author

@zz-jason it's 2.0, not 2.1

@zz-jason
Copy link
Member

/run-all-tests tikv=release-2.0 pd=release-2.0 tidb-test=release-2.0

@MyonKeminta
Copy link
Contributor Author

@winkyao PTAL thanks!

zz-jason
zz-jason previously approved these changes Nov 16, 2018
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason dismissed their stale review November 16, 2018 12:03

need one more reviewer.

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MyonKeminta
Copy link
Contributor Author

/run-all-tests tikv=release-2.0 pd=release-2.0 tidb-test=release-2.0

@winkyao winkyao merged commit 7ebfa28 into pingcap:release-2.0 Nov 19, 2018
@MyonKeminta MyonKeminta deleted the misono/2.0-scan-end-key branch November 19, 2018 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tikv status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants