-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix point get null values #7790
Conversation
/run-all-tests |
@zz-jason Another approach is more safe which is to modify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
/run-all-tests |
What problem does this PR solve?
Fix the "index out of range" panic caused by point getting all null values.
Let's say we have the following table:
In master branch, the following query can reach a panic:
This PR fixes the above problem.
What is changed and how it works?
if the length of the returned column values is smaller than the column offset, that indicates the value of that column is null or should be covered by the default value.
Check List
Tests