infoschema: Fix is.schemata to show correct charset/collation #7751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
morgo
changed the title
alivxxx
reviewed
Sep 20, 2018
| mysql.DefaultCollationName, // DEFAULT_COLLATION_NAME | ||
| catalogVal, // CATALOG_NAME | ||
| schema.Name.O, // SCHEMA_NAME | ||
| charset, // DEFAULT_CHARACTER_SET_NAME |
There was a problem hiding this comment.
It is better to update the comment to remove the DEFAULT prefix.
There was a problem hiding this comment.
As I understand, the comment refers to the structure of is.schemata. It remains correct with this patch:
mysql> SHOW CREATE TABLE schemata\G
*************************** 1. row ***************************
Table: SCHEMATA
Create Table: CREATE TABLE `SCHEMATA` (
`CATALOG_NAME` varchar(512) DEFAULT NULL,
`SCHEMA_NAME` varchar(64) DEFAULT NULL,
`DEFAULT_CHARACTER_SET_NAME` varchar(64) DEFAULT NULL,
`DEFAULT_COLLATION_NAME` varchar(32) DEFAULT NULL,
`SQL_PATH` varchar(512) DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin
1 row in set (0.01 sec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #7748
What is changed and how it works?
Prior to this fix, is.schemata used the global default charset, rather than the db specific default.
Check List
Tests
Code changes
Side effects
Unlikely
Related changes
None