*: disable read committed isolation level #7280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
reviewed
Aug 5, 2018
store/tikv/region_request.go
Outdated
| @@ -240,12 +240,5 @@ func (s *RegionRequestSender) onRegionError(bo *Backoffer, ctx *RPCContext, regi | |||
| } | |||
|
|
|||
| func pbIsolationLevel(level kv.IsoLevel) kvrpcpb.IsolationLevel { | |||
| switch level { | |||
There was a problem hiding this comment.
Analyze statement need to use RC isolation level.
shenli
added
the
priority/release-blocker
read committed isolation may cause inconsistent read. Only Analyze request use read committed isolation level.
coocood
force-pushed
the
disable-read-commit
branch
from
7507ab4
to
7a96a85
Compare
|
/run-all-tests |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read committed isolation may cause inconsistent read.
What have you changed? (mandatory)
disable read committed isolation level
What is the type of the changes? (mandatory)
How has this PR been tested? (mandatory)
Run concurrent DML statements with admin check table.
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
YES
Does this PR affect tidb-ansible update? (mandatory)
NO
Does this PR need to be added to the release notes? (mandatory)
YES
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)