kv: correct comments mistake. #6829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
29 tasks
|
LGTM |
zhexuany
reviewed
Jun 13, 2018
kv/txn.go
Outdated
| @@ -74,7 +74,7 @@ func RunInNewTxn(store Storage, retryable bool, f func(txn Transaction) error) e | |||
| } | |||
|
|
|||
| var ( | |||
| // Max retry count in RunInNewTxn | |||
| // maxRetryCnt in RunInNewTxn | |||
There was a problem hiding this comment.
maxRetryCnt represents maximum retry times in RunInNewTxn
There was a problem hiding this comment.
Add . at the end of a line
zhexuany
reviewed
Jun 13, 2018
kv/union_iter.go
Outdated
| @@ -47,14 +47,14 @@ func NewUnionIter(dirtyIt Iterator, snapshotIt Iterator, reverse bool) (*UnionIt | |||
| return it, nil | |||
| } | |||
|
|
|||
| // Go next and update valid status. | |||
| // dirtyNext and update valid status. | |||
There was a problem hiding this comment.
cc @winoros PTAL. I am not sure the correctness of comment.
There was a problem hiding this comment.
Better follow the pattern FuncName does something
zhexuany
reviewed
Jun 13, 2018
kv/union_iter.go
Outdated
| func (iter *UnionIter) dirtyNext() error { | ||
| err := iter.dirtyIt.Next() | ||
| iter.dirtyValid = iter.dirtyIt.Valid() | ||
| return errors.Trace(err) | ||
| } | ||
|
|
||
| // Go next and update valid status. | ||
| // snapshotNext and update valid status. |
zimulala
added
status/LGT1
Angryrou
force-pushed
the
fixed_correct_comments_mistake_in_kv
branch
from
032ab75 to
d3e4f49
Compare
zhexuany
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is referred to Issue #3120.