ddl: move auto id handling from submitter to executor (#62449)

[ti-chi-bot]

This is an automated cherry-pick of #62449

What problem does this PR solve?

Issue Number: close #60804

Problem Summary:

Previously, the procedure of (batch) creating table is as follow:

• submitter submit the job and wait it finished
• ddl owner execute the job and mark table as public
• submitter pre-scatter the table and update the auto id.

But if the submitter quit before waiting job finished, the post process will be skipped. So the creation itself is not atomic.

What changed and how does it work?

Now ddl owner takes the responsibility to update auto id and submitter only needs to pre-scatter the table.

tidb/pkg/ddl/job_submitter.go

Lines 224 to 227 in 1f24032

	if combinedJob == nil {
	combinedJob = job.Clone()
	combinedJob.Type = model.ActionCreateTables
	}

Because merged ddl job only holds the session variables from the first job for now, which means all jobs share the same variables, we don't apply pre-scatter in ddl owner.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

1. It must be approved by the approvers firstly.
2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tangenta for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

❌ Patch coverage is 82.35294% with 9 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.5@e4e814f). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-8.5     #64761   +/-   ##
================================================
  Coverage               ?   77.1522%           
================================================
  Files                  ?       1654           
  Lines                  ?     456066           
  Branches               ?          0           
================================================
  Hits                   ?     351865           
  Misses                 ?      82692           
  Partials               ?      21509           

Flag	Coverage Δ
integration	50.4577% <76.4705%> (?)
unit	72.6700% <82.3529%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9278% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	63.2355% <0.0000%> (?)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ti-chi-bot]

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-unit-test-ddlv1	ac0fc22	link	true	/test pull-unit-test-ddlv1

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.