*: make session variables control TiKV client variables. #6322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add a system variable `tidb_backoff_lock_fast` to change the backoff base time on read lock.
|
What's the benefit of this PR? |
tiancaiamao
reviewed
Apr 19, 2018
| @@ -223,7 +223,7 @@ func Select(ctx context.Context, sctx sessionctx.Context, kvReq *kv.Request, fie | |||
| if !sctx.GetSessionVars().EnableStreaming { | |||
| kvReq.Streaming = false | |||
| } | |||
| resp := sctx.GetClient().Send(ctx, kvReq) | |||
| resp := sctx.GetClient().Send(ctx, kvReq, sctx.GetSessionVars().KVVars) | |||
There was a problem hiding this comment.
Why not put it in kvReq ?
There was a problem hiding this comment.
the variables don't belong to the request.
It's long-term variables, only changed by explicit SET statement.
|
So we can experiment different values for better performance. |
coocood
changed the title
|
/run-all-tests |
|
LGTM |
zz-jason
approved these changes
Apr 20, 2018
|
I am testing the effect of performance of this pr. So wait to merge. |
coocood
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add a system variable
tidb_backoff_lock_fastto change the backoff base time on read lock.