Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: add recover to protect background task #58739

Merged
merged 3 commits into from
Jan 7, 2025
Merged

statistics: add recover to protect background task #58739

merged 3 commits into from
Jan 7, 2025

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 7, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58738

ref #58715

Problem Summary:

What changed and how does it work?

#58715 bug will panic in the background. it will make this background exiting and cannot restart it. it will lead many critical bug. so we need to add recover to protect the background thread.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

add recover to protect background task

增加recover 来保护后台任务意外退出

@hawkingrei
statistics: add recover to protect background task
d907e73 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/planner SIG: Planner and removed do-not-merge/needs-tests-checked labels Jan 7, 2025
@hawkingrei
Copy link
Member Author

/retest

@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.7367%. Comparing base (7063a6f) to head (668526a).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58739        +/-   ##
================================================
+ Coverage   73.0918%   73.7367%   +0.6449%     
================================================
  Files          1677       1707        +30     
  Lines        463763     473289      +9526     
================================================
+ Hits         338973     348988     +10015     
+ Misses       103926     102720      -1206     
- Partials      20864      21581       +717
Flag Coverage Δ
integration 45.6479% <33.3333%> (?)
unit 72.2830% <100.0000%> (-0.0025%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7449% <ø> (+0.0119%) ⬆️

@hawkingrei
update
32c2486 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
@hawkingrei
update
668526a 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-07 07:14:36.883680481 +0000 UTC m=+251420.172512186: ☑️ agreed by AilinKid.
  • 2025-01-07 07:39:18.277191141 +0000 UTC m=+252901.566022846: ☑️ agreed by time-and-fate.

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 23ed0df into pingcap:master Jan 7, 2025
25 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 7, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 7, 2025
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#58739
5ccb568 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5: #58763.

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 7, 2025
Open
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 7, 2025
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#58739
964ef56 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.1: #58764.

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 7, 2025
Open
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #58765.

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 7, 2025
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#58739
6753b5c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 7, 2025
Open
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 7, 2025
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#58739
2b2f629 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #58766.

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 7, 2025
Open
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.5: #58767.

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 7, 2025
Merged
13 tasks
@hawkingrei hawkingrei deleted the 58738 branch January 8, 2025 08:25
breezewish added a commit that referenced this pull request Jan 8, 2025
@breezewish
Merge commit '510d0037b18f258f505abc6cf13a8128563e9359' into wenxuan/…
3f825ba 
…long-vector

* commit '510d0037b18f258f505abc6cf13a8128563e9359':
  *: upgrade pd client to make sure tso client initiate successfully (#58752)
  ttl, test: scale TTL workers during the fault tests (#58750)
  planner: improve warning messages for unsupported HASH_JOIN hints (#58646)
  planner: prealloc the slices in the SplitCorColAccessCondFromFilters (#58785)
  ddl: supports non-unique global index (#58678)
  util/stmtsummary: add the network traffic related fields (#58101)
  var: enable `pd_enable_follower_handle_region` as default (#58385)
  statistics: refactor stats meta handling to use DeltaUpdate for multi-table support (#58657)
  parser: move 'model' to 'ast' pkg (#58704)
  statistics: add recover to protect background task (#58739)
  disttask: cancel subtask context if scheduled away (#58615)
  *: don't handle live updates of column size (#58596)
  *: fix a bug for default_authentication_plugin (2) (#58723)
  dupdetect: gRPC cancel should trigger retry (#58542)
  *: fix a bug for default_authentication_plugin (#57391)
  distsql: Fix backoff execution info inaccurate issue (#58707)
ti-chi-bot bot pushed a commit that referenced this pull request Jan 8, 2025
@ti-chi-bot
statistics: add recover to protect background task (#58739) (#58767)
1d198e6 
close #58738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add recover and Daemon Thread to key background tasks
4 participants
@hawkingrei @ti-chi-bot @AilinKid @time-and-fate