Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: set a lower limit of regions for distributed local sort #56613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #56501

Problem Summary: See #56501

What changed and how does it work?

// Assuming the region size is 96MiB and the index data size accounts for 1/10 of the row data.
// Row data take 960GiB for 10000 regions, and index data take 96GiB.
// This basically matches the default value of tidb_ddl_disk_quota.
// Estimates don't necessarily have to be accurate.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 12, 2024
Copy link

ti-chi-bot bot commented Oct 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tangenta, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 12, 2024
Copy link

tiprow bot commented Oct 12, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.8873%. Comparing base (025c2a3) to head (a01a9fd).

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56613         +/-   ##
=================================================
- Coverage   73.3320%   56.8873%   -16.4448%     
=================================================
  Files          1629       1778        +149     
  Lines        449708     636548     +186840     
=================================================
+ Hits         329780     362115      +32335     
- Misses        99711     249520     +149809     
- Partials      20217      24913       +4696     
Flag Coverage Δ
integration 39.0058% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1671% <ø> (+17.5756%) ⬆️

Copy link

ti-chi-bot bot commented Oct 12, 2024

@tangenta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-ddlv1 a01a9fd link true /test pull-unit-test-ddlv1
idc-jenkins-ci-tidb/unit-test a01a9fd link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regions number of one add-index subtask should be limited
1 participant