Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: set jobs dependency by schema and table name (#49699) #49782

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49699

What problem does this PR solve?

Issue Number: close #49498

Problem Summary:

We should also consider schema & table name before picking a DDL job to execute.

What changed and how does it work?

  • Extract ddl.runningJobs to a separate file.
  • Add AffectedSchemaNames and AffectedTableNames to model.Job.
  • Refine job depenency check.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 26, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 26, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 27, 2023
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 27, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 27, 2023
Copy link

ti-chi-bot bot commented Dec 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 27, 2023
Copy link

ti-chi-bot bot commented Dec 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-27 05:27:23.537487663 +0000 UTC m=+1629934.574714590: ☑️ agreed by Benjamin2037.
  • 2023-12-27 06:47:12.37122006 +0000 UTC m=+1634723.408446985: ☑️ agreed by zimulala.

@tangenta
Copy link
Contributor

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@81e3f34). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #49782   +/-   ##
================================================
  Coverage               ?   73.6947%           
================================================
  Files                  ?       1089           
  Lines                  ?     349938           
  Branches               ?          0           
================================================
  Hits                   ?     257886           
  Misses                 ?      75532           
  Partials               ?      16520           

@tangenta
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 88352e5 into pingcap:release-6.5 Dec 28, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants