Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: standardize some terminologies in binding pkg #48880

Merged
merged 3 commits into from
Nov 24, 2023
Merged

planner: standardize some terminologies in binding pkg #48880

merged 3 commits into from
Nov 24, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Nov 24, 2023

What problem does this PR solve?

Issue Number: ref #48875

Problem Summary: planner: standardize some terminologies in binding pkg

What changed and how does it work?

standardize hash and sqlDigest to sqlDigest, NO LOGICAL CHANGE, just update terminologies.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2023
@tiprow tiprow
Copy link

tiprow bot commented Nov 24, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 24, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 24, 2023 •
edited
Loading

Codecov Report

Merging #48880 (eb06323) into master (a0f5376) will increase coverage by 1.6430%.
Report is 1 commits behind head on master.
The diff coverage is 97.4359%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #48880        +/-   ##
================================================
+ Coverage   71.0046%   72.6476%   +1.6430%     
================================================
  Files          1368       1392        +24     
  Lines        404989     411625      +6636     
================================================
+ Hits         287561     299036     +11475     
+ Misses        97395      93670      -3725     
+ Partials      20033      18919      -1114
Flag Coverage Δ
integration 43.5936% <87.1794%> (?)
unit 71.0090% <97.2222%> (+0.0044%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8226% <ø> (-4.2732%) ⬇️

Rustin170506
Rustin170506 approved these changes Nov 24, 2023
View reviewed changes
pkg/bindinfo/handle.go
// GetBindRecord returns the BindRecord of the (normdOrigSQL,db) if BindRecord exist.
func (h *BindHandle) GetBindRecord(hash, normdOrigSQL, db string) *BindRecord {
return h.bindInfo.Load().(*bindCache).GetBindRecord(hash, normdOrigSQL, db)
// GetBindRecord returns the BindRecord of the (normalizedSQL,db) if BindRecord exist.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this to (sqlDigest, normalizedSQL, db)?

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 24, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-24 08:24:59.237610025 +0000 UTC m=+565527.902836217: ☑️ agreed by AilinKid.
  • 2023-11-24 09:04:04.163011581 +0000 UTC m=+567872.828237776: ☑️ agreed by hi-rustin.

@ti-chi-bot ti-chi-bot bot merged commit 15b7cdb into pingcap:master Nov 24, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qw4990 @AilinKid @Rustin170506