Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle: use logutil to unify the log category #48520

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 10, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

just a clean code.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Nov 10, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Nov 10, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #48520 (81d6047) into master (a05d70e) will increase coverage by 1.4267%.
Report is 3 commits behind head on master.
The diff coverage is 72.7272%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48520        +/-   ##
================================================
+ Coverage   71.3980%   72.8247%   +1.4267%     
================================================
  Files          1403       1427        +24     
  Lines        406975     413593      +6618     
================================================
+ Hits         290572     301198     +10626     
+ Misses        96449      93465      -2984     
+ Partials      19954      18930      -1024     
Flag Coverage Δ
integration 43.2794% <15.1515%> (?)
unit 71.4299% <69.6969%> (+0.0319%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8291% <ø> (-4.2719%) ⬇️

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot removed the approved label Nov 10, 2023
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 10, 2023
Copy link

ti-chi-bot bot commented Nov 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-10 09:07:51.820904525 +0000 UTC m=+3808069.408014655: ☑️ agreed by qw4990.
  • 2023-11-10 09:31:38.760837658 +0000 UTC m=+3809496.347947802: ☑️ agreed by zimulala.

@ti-chi-bot ti-chi-bot bot merged commit 44f9430 into pingcap:master Nov 10, 2023
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants