Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade go1.21.4 #48373

Merged
merged 1 commit into from
Nov 9, 2023
Merged

*: upgrade go1.21.4 #48373

merged 1 commit into from
Nov 9, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 7, 2023

What problem does this PR solve?

Issue Number: close #48383

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked do-not-merge/needs-linked-issue labels Nov 7, 2023
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

@bb7133 PTAL

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #48373 (e294f13) into master (633d223) will increase coverage by 1.9425%.
Report is 23 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48373        +/-   ##
================================================
+ Coverage   71.3791%   73.3216%   +1.9425%     
================================================
  Files          1402       1425        +23     
  Lines        406780     418276     +11496     
================================================
+ Hits         290356     306687     +16331     
+ Misses        96504      92769      -3735     
+ Partials      19920      18820      -1100     
Flag Coverage Δ
integration 44.0620% <ø> (?)
unit 71.9885% <ø> (+0.6093%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8406% <ø> (-4.0762%) ⬇️

@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Nov 8, 2023

@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build e294f13 link true /test build
idc-jenkins-ci-tidb/unit-test e294f13 link true /test unit-test
Full PR test history. Your PR dashboard.

TestSortSpillDisk failed 3 times:

=== RUN   TestSortSpillDisk
[2023/11/08 10:08:34.153 +08:00] [INFO] [row_container.go:436] ["memory exceeds quota, spill to disk now."] [consumed=8192] [quota=1]
    executor_pkg_test.go:346: 
        	Error Trace:	pkg/executor/executor_pkg_test.go:346
        	Error:      	Not equal: 
        	            	expected: true
        	            	actual  : false
        	Test:       	TestSortSpillDisk
--- FAIL: TestSortSpillDisk (0.01s)

TestVerifyCommonNameAndRotate failed:

=== RUN   TestVerifyCommonNameAndRotate
2023/11/08 09:59:17 http: TLS handshake error from 127.0.0.1:34556: client certificate authentication failed. The Common Name from the client certificate [client2 ] was not found in the configuration cluster-verify-cn with value: [client1]
    security_test.go:115: 
        	Error Trace:	pkg/util/security_test.go:115
        	Error:      	Error "Get \"https://127.0.0.1:9292\": write tcp 127.0.0.1:34556->127.0.0.1:9292: write: broken pipe" does not contain "tls: bad certificate"
        	Test:       	TestVerifyCommonNameAndRotate
--- FAIL: TestVerifyCommonNameAndRotate (18.18s)

@hawkingrei
Copy link
Member Author

@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build e294f13 link true /test build
idc-jenkins-ci-tidb/unit-test e294f13 link true /test unit-test
Full PR test history. Your PR dashboard.

TestSortSpillDisk failed 3 times:

=== RUN   TestSortSpillDisk
[2023/11/08 10:08:34.153 +08:00] [INFO] [row_container.go:436] ["memory exceeds quota, spill to disk now."] [consumed=8192] [quota=1]
    executor_pkg_test.go:346: 
        	Error Trace:	pkg/executor/executor_pkg_test.go:346
        	Error:      	Not equal: 
        	            	expected: true
        	            	actual  : false
        	Test:       	TestSortSpillDisk
--- FAIL: TestSortSpillDisk (0.01s)

TestVerifyCommonNameAndRotate failed:

=== RUN   TestVerifyCommonNameAndRotate
2023/11/08 09:59:17 http: TLS handshake error from 127.0.0.1:34556: client certificate authentication failed. The Common Name from the client certificate [client2 ] was not found in the configuration cluster-verify-cn with value: [client1]
    security_test.go:115: 
        	Error Trace:	pkg/util/security_test.go:115
        	Error:      	Error "Get \"https://127.0.0.1:9292\": write tcp 127.0.0.1:34556->127.0.0.1:9292: write: broken pipe" does not contain "tls: bad certificate"
        	Test:       	TestVerifyCommonNameAndRotate
--- FAIL: TestVerifyCommonNameAndRotate (18.18s)

I think you should carefully consider why many errors only occur on your end and not on tiprow?

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 8, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 8, 2023
Copy link

ti-chi-bot bot commented Nov 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-08 02:54:13.554852307 +0000 UTC m=+3612851.141962437: ☑️ agreed by xhebox.
  • 2023-11-08 02:55:49.182714972 +0000 UTC m=+3612946.769825119: ☑️ agreed by Defined2014.

@hawkingrei
Copy link
Member Author

hawkingrei commented Nov 8, 2023

/hold

@bb7133 The control of merging is now in your hands.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2023
@hawkingrei
Copy link
Member Author

/test all

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, Defined2014, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,bb7133,xhebox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei
Copy link
Member Author

/unhold
/retest

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2023
@ti-chi-bot ti-chi-bot bot merged commit 30e7162 into pingcap:master Nov 9, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade Go 1.21.4 and 1.20.11
5 participants