-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: avoid using too new syntax features #48254
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48254 +/- ##
================================================
+ Coverage 71.4915% 72.8740% +1.3824%
================================================
Files 1402 1425 +23
Lines 406217 413118 +6901
================================================
+ Hits 290411 301056 +10645
+ Misses 95973 93180 -2793
+ Partials 19833 18882 -951
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
723de3d
to
4308429
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test unit-test |
@hawkingrei: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: close #48066
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.