-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: upgrade rules_go and tools #48222
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48222 +/- ##
================================================
+ Coverage 71.5384% 72.8205% +1.2820%
================================================
Files 1402 1425 +23
Lines 406159 412709 +6550
================================================
+ Hits 290560 300537 +9977
+ Misses 95775 93294 -2481
+ Partials 19824 18878 -946
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fa75dbd
to
bafc8d4
Compare
/retest |
1 similar comment
/retest |
/test all |
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
@hawkingrei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.