Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Makefile: correct calling of make #47944

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Oct 24, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

Use the MAKE variable to call make. This ensures the make we call is the correct one. This is mostly important on systems where make isn't GNU make and where make is called via gmake ...

https://www.gnu.org/software/make/manual/make.html#MAKE-Variable

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@dveeden dveeden added the skip-issue-check Indicates that a PR no need to check linked issue. label Oct 24, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2023
@tiprow
Copy link

tiprow bot commented Oct 24, 2023

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #47944 (b04cbbf) into master (f4a139f) will increase coverage by 0.9651%.
Report is 30 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47944        +/-   ##
================================================
+ Coverage   71.8610%   72.8261%   +0.9651%     
================================================
  Files          1398       1424        +26     
  Lines        405256     412040      +6784     
================================================
+ Hits         291221     300073      +8852     
+ Misses        94397      93072      -1325     
+ Partials      19638      18895       -743     
Flag Coverage Δ
integration 41.8408% <ø> (?)
unit 71.7764% <ø> (-0.0847%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7357% <ø> (-4.2318%) ⬇️

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 25, 2023
@CbcWestwolf
Copy link
Member

/cc xhebox

@ti-chi-bot ti-chi-bot bot requested a review from xhebox October 25, 2023 02:42
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 25, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-25 02:15:22.651764278 +0000 UTC m=+2400920.238874423: ☑️ agreed by hawkingrei.
  • 2023-10-25 02:56:00.260949999 +0000 UTC m=+2403357.848060131: ☑️ agreed by lcwangchao.

@ti-chi-bot ti-chi-bot bot merged commit ebe8ca7 into pingcap:master Oct 25, 2023
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants