-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Makefile: correct calling of make #47944
Conversation
Hi @dveeden. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47944 +/- ##
================================================
+ Coverage 71.8610% 72.8261% +0.9651%
================================================
Files 1398 1424 +26
Lines 405256 412040 +6784
================================================
+ Hits 291221 300073 +8852
+ Misses 94397 93072 -1325
+ Partials 19638 18895 -743
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/cc xhebox |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
Use the
MAKE
variable to call make. This ensures the make we call is the correct one. This is mostly important on systems wheremake
isn't GNU make and where make is called viagmake ...
https://www.gnu.org/software/make/manual/make.html#MAKE-Variable
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.