Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add variable to control async merge global stats #47806

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Oct 19, 2023

What problem does this PR solve?

Issue Number: ref #47275

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-tests-checked do-not-merge/needs-linked-issue labels Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #47806 (77751fe) into master (f4a139f) will increase coverage by 0.9301%.
Report is 9 commits behind head on master.
The diff coverage is 48.8235%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47806        +/-   ##
================================================
+ Coverage   71.8610%   72.7911%   +0.9301%     
================================================
  Files          1398       1422        +24     
  Lines        405256     411862      +6606     
================================================
+ Hits         291221     299799      +8578     
+ Misses        94397      93196      -1201     
+ Partials      19638      18867       -771     
Flag Coverage Δ
integration 41.4482% <2.3529%> (?)
unit 71.8557% <48.8235%> (-0.0053%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7187% <ø> (-4.2488%) ⬇️

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may need to add a bootstrap upgrade func to make the upgraded cluster keep the old behavior

*
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 20, 2023
*
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
*
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 20, 2023
@easonn7
Copy link

easonn7 commented Oct 20, 2023

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Oct 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-20 07:01:44.343658023 +0000 UTC m=+1986101.930768164: ☑️ agreed by qw4990.
  • 2023-10-20 08:21:20.066312639 +0000 UTC m=+1990877.653422780: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit 1501bf1 into pingcap:master Oct 20, 2023
12 of 16 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #47880.

hawkingrei added a commit to ti-chi-bot/tidb that referenced this pull request Oct 26, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants