Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix the issue that binding for in (?) cannot work for in (?,?,?) #46896

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 12, 2023

What problem does this PR solve?

Issue Number: ref #44298

Problem Summary: planner: fix the issue that binding for in (?) cannot work for in (?,?,?)

What is changed and how it works?

Following #44601, fix some compatibility issues.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2023
@tiprow
Copy link

tiprow bot commented Sep 12, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 12, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-12 07:43:44.380188651 +0000 UTC m=+341606.304745031: ☑️ agreed by hawkingrei.
  • 2023-09-12 07:55:19.688271376 +0000 UTC m=+342301.612827771: ☑️ agreed by AilinKid.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #46896 (30ee2b2) into master (7b288bf) will increase coverage by 0.0182%.
Report is 11 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46896        +/-   ##
================================================
+ Coverage   73.3674%   73.3857%   +0.0182%     
================================================
  Files          1328       1331         +3     
  Lines        397100     397681       +581     
================================================
+ Hits         291342     291841       +499     
- Misses        87162      87226        +64     
- Partials      18596      18614        +18     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3776% <100.0000%> (+0.0101%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0019% <ø> (+0.0107%) ⬆️
br 52.9134% <ø> (+0.0655%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 2db6c0a into pingcap:master Sep 12, 2023
16 checks passed
@qw4990 qw4990 added the type/bugfix This PR fixes a bug. label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved epic/sql-plan-management lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants