Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove useless code #4672

Merged
merged 5 commits into from
Sep 28, 2017
Merged

Conversation

zz-jason
Copy link
Member

No description provided.

@shenli
Copy link
Member

shenli commented Sep 28, 2017

/run-all-tests

@ngaut
Copy link
Member

ngaut commented Sep 28, 2017

LGTM

coocood
coocood previously approved these changes Sep 28, 2017
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanfei1991
Copy link
Member

It seems argValues can also be removed.

@zz-jason zz-jason changed the title expression: remove function "evalArgs()" expression: remove useless code Sep 28, 2017
@hanfei1991
Copy link
Member

LGTM

Copy link
Member

@hanfei1991 hanfei1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanfei1991 hanfei1991 merged commit 459c469 into master Sep 28, 2017
@hanfei1991 hanfei1991 deleted the zz-jason/expression/evalArgs branch September 28, 2017 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants