Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: introduce a new empirical rule into the Skyline pruning #46559

Merged
merged 8 commits into from
Sep 1, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Aug 31, 2023

What problem does this PR solve?

Issue Number: close #45132

Problem Summary: planner: introduce a new empirical rule into the Skyline pruning

What is changed and how it works?

Add a new empirical rule to the Skyline pruning: If x's range row count is significantly lower than y's, for example, 1000 times, we think x is better than y and prune y from the candidate.

Use fixcontrol to control this behavior.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 31, 2023
@tiprow
Copy link

tiprow bot commented Aug 31, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #46559 (0e474d3) into master (d36478f) will decrease coverage by 0.6857%.
Report is 6 commits behind head on master.
The diff coverage is 80.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46559        +/-   ##
================================================
- Coverage   73.3392%   72.6536%   -0.6857%     
================================================
  Files          1309       1330        +21     
  Lines        394535     400773      +6238     
================================================
+ Hits         289349     291176      +1827     
- Misses        86772      91119      +4347     
- Partials      18414      18478        +64     
Flag Coverage Δ
integration 25.3961% <60.0000%> (?)
unit 73.3411% <80.0000%> (+0.0019%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 84.9772% <ø> (ø)
br 48.0054% <ø> (-4.3453%) ⬇️

@qw4990 qw4990 added the sig/planner SIG: Planner label Aug 31, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 31, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Aug 31, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 31, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 31, 2023
@tiprow
Copy link

tiprow bot commented Sep 1, 2023

@qw4990: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 0e474d3 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 1, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Sep 1, 2023

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 1, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 1, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-31 10:24:54.342346186 +0000 UTC m=+2009058.891362173: ☑️ agreed by hawkingrei.
  • 2023-09-01 04:15:03.74173876 +0000 UTC m=+2073268.290754747: ☑️ agreed by time-and-fate.

@qw4990
Copy link
Contributor Author

qw4990 commented Sep 1, 2023

/test unit-test

@tiprow
Copy link

tiprow bot commented Sep 1, 2023

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 80da849 into pingcap:master Sep 1, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
3 participants