disttask: fix wrongly add subtask when state transform fail

[ywqzzy]

What problem does this PR solve?

Issue Number: close #46261 ref #46258

Problem Summary:
see #46261

1. When state transform fails, framework still adds subtasks.
2. can't transform state from cancelling to reverted.(If there are no subtasks for task submitted, this state transform is legal.)

What is changed and how it works?

1. When state transform fails, check the affected row cnt to skip adding subtask. This error should not be retryable.
2. When there are no subtasks submitted and the task is canceled, the state transform will be canceling--->reverting--->reverted. Remove the old fast path: canceling--->reverted.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #46259 (512e706) into master (e8ca3d4) will decrease coverage by 0.5226%.
Report is 29 commits behind head on master.
The diff coverage is 65.2173%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #46259        +/-   ##
================================================
- Coverage   73.3713%   72.8487%   -0.5226%     
================================================
  Files          1285       1309        +24     
  Lines        394530     400667      +6137     
================================================
+ Hits         289472     291881      +2409     
- Misses        86617      90406      +3789     
+ Partials      18441      18380        -61     

Flag	Coverage Δ
integration	25.8097% <0.0000%> (?)
unit	73.5277% <78.9473%> (+0.1563%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	54.0444% <ø> (ø)
parser	85.0813% <ø> (+0.0048%)	⬆️
br	47.9769% <ø> (-4.2737%)	⬇️

[hawkingrei]

/ok-to-test

[GMHDBJD]

LGTM

[D3Hunter]

/lgtm

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [D3Hunter,GMHDBJD]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-08-23 07:20:07.602005334 +0000 UTC m=+1306772.151021321: ☑️ agreed by GMHDBJD.
• 2023-08-23 08:33:36.466752687 +0000 UTC m=+1311181.015768674: ☑️ agreed by D3Hunter.